Changeset 18:40ba502fe87e in mailjam

Timestamp:

May 22, 2012, 1:26:27 PM (13 years ago)

Author:

Borja Lopez <borja@…>

Branch:

default

Phase:

public

Message:

Fixed a bug in the code that loads python objects from json dumps.

This bug was raising TypeError exceptions when the dumped object contained
more attributes defined in the init method than the arguments accepted
by the init method itself.

(You can reproduce this error in previous revisions of the code by dumping
a mailjam.models.MailingList object and then trying to load it from the
json dump).

File:

• mailjam/storage.py (modified) (2 diffs)

mailjam/storage.py

@@ -11 +11 @@
 """
 
-import os, errno, json
+import os, errno, json, inspect
 
 
@@ -63 +63 @@
             module = __import__(module_name)
             class_ = getattr(module, class_name)
+            # inspect the class __init__ method, getting a list of
+            # accepted/valid arguments.
+            valid_args = inspect.getargspec(class_.__init__)
+            # then, only accepted parameters will be deserialized
             args = dict((key.encode('ascii'), value) \
-                        for key, value in jobj.items())
+                        for key, value in jobj.items() if key in valid_args[0])
             return class_(**args)
         return jobj