Changes in / [37:fe97cac0645e:38:77d4f71ee2a7] in pyenvjasmine

Files:

• MANIFEST (modified) (1 diff)
• pyenvjasmine/envjasmine/lib/jasmine-3.1.0/boot.js (added)
• pyenvjasmine/envjasmine/lib/jasmine-3.1.0/jasmine-html.js (added)
• pyenvjasmine/envjasmine/lib/jasmine-3.1.0/jasmine.css (added)
• pyenvjasmine/envjasmine/lib/jasmine-3.1.0/jasmine.js (added)
• pyenvjasmine/envjasmine/lib/jasmine-jquery/jasmine3-jquery.js (added)
• pyenvjasmine/run-jasmine3.js (added)
• pyenvjasmine/runner.html (modified) (2 diffs)
• pyenvjasmine/runner.py (modified) (8 diffs)
• pyenvjasmine/runner3.html (added)
• pyenvjasmine/tests/sample/browser.configfile.js (modified) (1 diff)
• pyenvjasmine/tests/sample/browser.configfile_no_mocks.js (added)
• pyenvjasmine/tests/test_runner.py (modified) (7 diffs)

MANIFEST

@@ -1 +1 @@
 # file GENERATED by distutils, do NOT edit
 README
+setup.cfg
 setup.py
 pyenvjasmine/__init__.py

pyenvjasmine/runner.html

@@ -8 +8 @@
     <script type="text/javascript" src="file:///%(libDir)s/envjasmine/lib/jasmine/jasmine.js"></script>
     <script type="text/javascript" src="file:///%(libDir)s/envjasmine/lib/jasmine/jasmine-html.js"></script>
-    <script type="text/javascript" src="file:///%(libDir)s/envjasmine/lib/jasmine-ajax/mock-ajax.js"></script>
-    <script type="text/javascript" src="file:///%(libDir)s/envjasmine/lib/jasmine-ajax/spec-helper.js"></script>
-    <script type="text/javascript" src="file:///%(libDir)s/envjasmine/lib/jasmine-jquery/jasmine-jquery.js"></script>
 
     <script type="text/javascript" src="browser.runner.js"></script>
@@ -43 +40 @@
       EnvJasmine.jsDir = "";
       EnvJasmine.testDir = "%(testDir)s";
+      EnvJasmine.envJasmineLibDir = 'file:///%(libDir)s/envjasmine/lib';
 
       EnvJasmine.load = function (path) {

pyenvjasmine/runner.py

@@ -89 +89 @@
 
     watchdog.cancel()  # if it's still waiting to run
-
     # if it timed out, success is False
     success = (not kill_check.isSet()) and p.returncode >= 0
@@ -95 +94 @@
     return (success, ''.join(stdout_l), stderr)
 
-
 class Runner(object):
     """
@@ -105 +103 @@
 
     def __init__(self, rootdir=None, testdir=None, configfile=None,
-                 browser_configfile=None):
+                 browser_configfile=None, testing_enviroment='phantomjs'):
         """
         Set up paths, by default everything is
@@ -127 +125 @@
         self.configfile = configfile
         self.browser_configfile = browser_configfile
-        self.runner_html = os.path.join(here, 'runner.html')
-
-    def run(self, spec=None, timeout=None):
-        """
-        Run the js tests with envjasmine, return success (true/false) and
-        the captured stdout data
-
-        spec: (relative) path to a spec file (run only that spec)
-        timeout: Set it to a given number of seconds and the process running
-                 the js tests will be killed passed that time
-        """
+        self.runner_js = os.path.join(here, 'run-jasmine3.js')
+        self.testing_enviroment = testing_enviroment
         environment = get_environment()
         rhino_path = os.path.join(self.rootdir, 'lib', 'rhino', 'js.jar')
@@ -143 +132 @@
         rootdir_param = '--rootDir=%s' % self.rootdir
         testdir_param = '--testDir=%s' % self.testdir
+
+        # using a dictionary to parameterize the different engines
+        self.envs = {
+            'phantomjs' : {
+                'command' : [
+                    'phantomjs',
+                    '--debug=true',
+                    self.runner_js,
+                    'browser.runner.html'
+                ],
+                'runner_html' : 'runner3.html',
+                'failed_mark' : 'FAILED',
+                'success_mark' : '0 failures'
+            },
+            'rhino' : {
+                'command' : [
+                    'java',
+                    '-Duser.timezone=US/Eastern',
+                    '-Dfile.encoding=utf-8',
+                    '-jar',
+                    rhino_path,
+                    envjasmine_js_path,
+                    '--disableColor',
+                    environment,
+                    rootdir_param,
+                    testdir_param
+                ],
+                'runner_html' : 'runner.html',
+                'failed_mark' : 'FAILED',
+                'success_mark' : 'Failed: 0',
+                'command_params_func' : self.command_params_rhino
+            }
+        }
+        self.runner_html = os.path.join(here,
+                              self.envs[self.testing_enviroment]['runner_html'])
+
+    def command_params_rhino(self, command):
+        """
+        Function specific to Rhino to add eventual arguments to the command line.
+        The function is referenced in the dictionary "envs" with key
+        "command_params_func", and for every engine that needs the same type of
+        manipulation there will be a similar function with relative reference in
+        the dictionary
+        """
+        if self.configfile and os.path.exists(self.configfile):
+           command.append('--configFile=%s' % self.configfile)
+        return command
+
+    def run(self, spec=None, timeout=None):
+        """
+        Run the js tests with envjasmine, return success (true/false) and
+        the captured stdout data
+
+        spec: (relative) path to a spec file (run only that spec)
+        timeout: Set it to a given number of seconds and the process running
+                 the js tests will be killed passed that time
+        """
         if self.browser_configfile and os.path.exists(self.browser_configfile):
             self.write_browser_htmlfile()
-
-        command = [
-            'java',
-            '-Duser.timezone=US/Eastern',
-            '-Dfile.encoding=utf-8',
-            '-jar',
-            rhino_path,
-            envjasmine_js_path,
-            '--disableColor',
-            environment,
-            rootdir_param,
-            testdir_param
-            ]
-
-        if self.configfile and os.path.exists(self.configfile):
-            command.append('--configFile=%s' % self.configfile)
-
+        command = self.envs[self.testing_enviroment]['command']
+        # Add eventual other parameters to the command by calling a
+        # function specific for the selected engine (rhino, phantomjs, etc.)
+        if 'command_params_func' in self.envs[self.testing_enviroment]:
+            command = self.envs[self.testing_enviroment]['command_params_func'](command)
         # if we were asked to test only some of the spec files,
         # addd them to the command line:
@@ -174 +208 @@
         stderr = subprocess.PIPE
         input_data = ''
-
         success, stdout, stderr = run_popen_with_timeout(
             command, timeout, input_data, stdin, stdout, stderr
@@ -186 +219 @@
 
     def did_test_pass(self, stdout):
-        if 'FAILED' in stdout:
+        if self.envs[self.testing_enviroment]['failed_mark'] in stdout:
             # it can happen that a test fails because of some timing issues
             # (timer error). In such case it may happen that the test does
@@ -198 +231 @@
         # tests passing ok
         for line in stdout.splitlines():
-            if 'Failed' in line:
-                failed = line.split(':')[1].strip()
-                return failed == '0'
+            if self.envs[self.testing_enviroment]['success_mark'] in line:
+                return True
         return False
 

pyenvjasmine/tests/sample/browser.configfile.js

@@ -6 +6 @@
 EnvJasmine.jsDir = EnvJasmine.testDir + "/code/";
 EnvJasmine.loadGlobal(EnvJasmine.includeDir + "jquery-1.4.4.js");
+EnvJasmine.loadGlobal(EnvJasmine.testDir + '/code/demo.js');
+EnvJasmine.loadGlobal(EnvJasmine.testDir + '/mocks/demo.mock.js');
+EnvJasmine.loadGlobal(EnvJasmine.testDir + '/tests/specs/test_demo.spec.js');

pyenvjasmine/tests/test_runner.py

@@ -5 +5 @@
 
 
-class TestsRunner(object):
+class TestsRunnerRhino(object):
+
+    """
+    Run the full tests using the old rhino+jasmine1 env
+    """
 
     def test_runner_defaults(self):
@@ -11 +15 @@
         Test the runner, using default values (which wil run the demo specs)
         """
-        jstests = Runner()
+        jstests = Runner(testing_enviroment='rhino')
         success, stdout = jstests.run()
         assert success
@@ -26 +30 @@
         envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
         jstests = Runner(
+            testing_enviroment='rhino',
             rootdir=envjasmine_dir,
             testdir=sample,
@@ -47 +52 @@
         envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
         jstests = Runner(
+            testing_enviroment='rhino',
             rootdir=envjasmine_dir,
             testdir=sample,
@@ -68 +74 @@
         envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
         jstests = Runner(
+            testing_enviroment='rhino',
             rootdir=envjasmine_dir,
             testdir=sample,
@@ -97 +104 @@
         # but we want to test also the case when a test failed
         # and it does not appear in the "Failed:" report
-        jstests = Runner()
+        jstests = Runner(testing_enviroment='rhino')
         success = jstests.did_test_pass('')
         assert not success
@@ -120 +127 @@
         success = jstests.did_test_pass('Failed: something-not-a-number')
         assert not success
+
+class TestsRunnerPhantomjs(object):
+
+    """
+    Run the full tests using the phantom+jasmine3 env
+    """
+
+    def test_write_browser_htmlfile_markup_is_correct(self):
+        """
+        Test the created markup
+        The config file doesn't contain the mock files so jasmine tests
+        are expected to fail
+        """
+        here = os.path.dirname(__file__)
+        sample = os.path.join(here, 'sample')
+        browser_conf_file = os.path.join(sample, 'browser.configfile_no_mocks.js')
+        envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
+        jstests = Runner(
+            testing_enviroment='phantomjs',
+            rootdir=envjasmine_dir,
+            testdir=sample,
+            browser_configfile=browser_conf_file
+        )
+        expected = jstests.create_testRunnerHtml()
+        jstests.write_browser_htmlfile()
+        success, stdout = jstests.run()
+        assert not success
+        assert '2 test(s) FAILED:' in stdout
+        with open("browser.runner.html",'r') as file:
+            actual = file.read()
+            assert expected == actual
+
+    def test_runner_with_browser_configfile(self):
+        """
+        Test the runner, giving it some parameters incl the browser config file
+        The config file contains the mock files so jasmine tests are expected
+        to pass
+        """
+        here = os.path.dirname(__file__)
+        sample = os.path.join(here, 'sample')
+        browser_conf_file = os.path.join(sample, 'browser.configfile.js')
+        envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
+        jstests = Runner(
+            testing_enviroment='phantomjs',
+            rootdir=envjasmine_dir,
+            testdir=sample,
+            browser_configfile=browser_conf_file
+        )
+        success, stdout = jstests.run()
+        assert success
+        assert '0 failures' in stdout
+
+    def test_did_test_pass(self):
+        # there is some coverage done with the previous tests,
+        # but we want to test also the case when a test failed
+        # and it does not appear in the "Failed:" report
+        here = os.path.dirname(__file__)
+        sample = os.path.join(here, 'sample')
+        browser_conf_file = os.path.join(sample, 'browser.configfile.js')
+
+        jstests = Runner(
+            testing_enviroment='phantomjs',
+            browser_configfile=browser_conf_file
+        )
+        success = jstests.did_test_pass('')
+        assert not success
+        success = jstests.did_test_pass('some random data '*50)
+        assert not success
+        success = jstests.did_test_pass('some data FAILED some more data')
+        assert not success
+        success = jstests.did_test_pass('some data FAILEDsome more data')
+        assert not success
+        success = jstests.did_test_pass('0 failures')
+        assert success
+        success = jstests.did_test_pass('0 failures FAILED')
+        assert not success
+        success = jstests.did_test_pass('0Failed: failures')
+        assert not success
+        success = jstests.did_test_pass('1 test(s) FAILED:')
+        assert not success
+        success = jstests.did_test_pass('-11 test(s) FAILED:')
+        assert not success
+        success = jstests.did_test_pass('something-not-a-number test(s) FAILED:')
+        assert not success