Changeset 42:a67c2fe2b2aa in pyenvjasmine

Timestamp:

Apr 3, 2018, 1:57:36 PM (6 years ago)

Author:

Borja Lopez <borja@…>

Branch:

default

Phase:

public

Message:

Fixed typo (enviroment/environment)

Location:

pyenvjasmine

Files:

• runner.py (modified) (6 diffs)
• tests/test_runner.py (modified) (8 diffs)

pyenvjasmine/runner.py

@@ -103 +103 @@
 
     def __init__(self, rootdir=None, testdir=None, configfile=None,
-                 browser_configfile=None, testing_enviroment='phantomjs'):
+                 browser_configfile=None, testing_environment='phantomjs'):
         """
         Set up paths, by default everything is
@@ -126 +126 @@
         self.browser_configfile = browser_configfile
         self.runner_js = os.path.join(here, 'run-jasmine3.js')
-        self.testing_enviroment = testing_enviroment
+        self.testing_environment = testing_environment
         environment = get_environment()
         rhino_path = os.path.join(self.rootdir, 'lib', 'rhino', 'js.jar')
@@ -166 +166 @@
         }
         self.runner_html = os.path.join(here,
-                              self.envs[self.testing_enviroment]['runner_html'])
+                              self.envs[self.testing_environment]['runner_html'])
 
     def command_params_rhino(self, command):
@@ -191 +191 @@
         if self.browser_configfile and os.path.exists(self.browser_configfile):
             self.write_browser_htmlfile()
-        command = self.envs[self.testing_enviroment]['command']
+        command = self.envs[self.testing_environment]['command']
         # Add eventual other parameters to the command by calling a
         # function specific for the selected engine (rhino, phantomjs, etc.)
-        if 'command_params_func' in self.envs[self.testing_enviroment]:
-            command = self.envs[self.testing_enviroment]['command_params_func'](command)
+        if 'command_params_func' in self.envs[self.testing_environment]:
+            command = self.envs[self.testing_environment]['command_params_func'](command)
         # if we were asked to test only some of the spec files,
         # addd them to the command line:
@@ -219 +219 @@
 
     def did_test_pass(self, stdout):
-        if self.envs[self.testing_enviroment]['failed_mark'] in stdout:
+        if self.envs[self.testing_environment]['failed_mark'] in stdout:
             # it can happen that a test fails because of some timing issues
             # (timer error). In such case it may happen that the test does
@@ -231 +231 @@
         # tests passing ok
         for line in stdout.splitlines():
-            if self.envs[self.testing_enviroment]['success_mark'] in line:
+            if self.envs[self.testing_environment]['success_mark'] in line:
                 return True
         return False

pyenvjasmine/tests/test_runner.py

@@ -14 +14 @@
         Test the runner, using default values (which wil run the demo specs)
         """
-        jstests = Runner(testing_enviroment='rhino')
+        jstests = Runner(testing_environment='rhino')
         success, stdout = jstests.run()
         assert success
@@ -29 +29 @@
         envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
         jstests = Runner(
-            testing_enviroment='rhino',
+            testing_environment='rhino',
             rootdir=envjasmine_dir,
             testdir=sample,
@@ -51 +51 @@
         envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
         jstests = Runner(
-            testing_enviroment='rhino',
+            testing_environment='rhino',
             rootdir=envjasmine_dir,
             testdir=sample,
@@ -73 +73 @@
         envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
         jstests = Runner(
-            testing_enviroment='rhino',
+            testing_environment='rhino',
             rootdir=envjasmine_dir,
             testdir=sample,
@@ -103 +103 @@
         # but we want to test also the case when a test failed
         # and it does not appear in the "Failed:" report
-        jstests = Runner(testing_enviroment='rhino')
+        jstests = Runner(testing_environment='rhino')
         success = jstests.did_test_pass('')
         assert not success
@@ -144 +144 @@
         envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
         jstests = Runner(
-            testing_enviroment='phantomjs',
+            testing_environment='phantomjs',
             rootdir=envjasmine_dir,
             testdir=sample,
@@ -169 +169 @@
         envjasmine_dir = os.path.join(os.path.dirname(here), 'envjasmine')
         jstests = Runner(
-            testing_enviroment='phantomjs',
+            testing_environment='phantomjs',
             rootdir=envjasmine_dir,
             testdir=sample,
@@ -187 +187 @@
 
         jstests = Runner(
-            testing_enviroment='phantomjs',
+            testing_environment='phantomjs',
             browser_configfile=browser_conf_file
         )