Changeset 4:14b2a12d495e in mailjam for postman

Timestamp:

May 15, 2012, 4:41:48 PM (12 years ago)

Author:

Francisco de Borja Lopez Rio <borja@…>

Branch:

default

Phase:

public

Message:

Fixed some bugs in the code that was doing the de-serialization of data from
json-encoded files.

One of the bugs raised an exception complaining about the Member, MailingList
and JsonStorage classes not being found when de-serializing objects that
contain instances of such classes in their attributes. I fixed it adding some
imports to the init.py file within the postman/ module

The other bug was causing an infinite loop that was triggering a RuntimeError
(maximum recursion depth exceeded) when de-serializing MailingList instances
(a call to the .load() method in the init method of the MailingList class
was causing it)

Location:

postman

Files:

• __init__.py (modified) (1 diff)
• models.py (modified) (2 diffs)
• storage.py (modified) (1 diff)

postman/__init__.py

@@ +1 @@
+# -*- coding: utf-8 -*-
+
+from models import Member, MailingList
+from storage import JsonStorage

postman/models.py

@@ -42 +42 @@
                                             self.address))
         self.archive = Storage(os.path.join(self.config['archive'],
-                                            self.address))
-        # try to load data from the storage
-        loaded = self.load()
-        # FIXME: if loaded is False, the storage does not exist, perhaps
-        # this would be a good place to create it for the first time
-
+                                            self.address))        
+        
     def __repr__(self):
         return "<MailingList '%s'>" % self.address
@@ -76 +72 @@
             raise ValueError(address, ' is not a valid email address')
         return address in self.members_addresses()
-
+        
     def members_addresses(self):
         return self.members.keys()

postman/storage.py

@@ -21 +21 @@
         Convert objects to a dictionary of their representation
         Based on the exmplaes from Doyg Hellmann:
-        http://www.doughellmann.com/PyMOTW/json/#working-with-your-own-types        
+        http://www.doughellmann.com/PyMOTW/json/#working-with-your-own-types
         """
         jobj = { '__class__':obj.__class__.__name__,